Model version setting option and Faraday deprecation fixes #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2018-12-01. Gem::Specification#has_rdoc= called from /Users/evgeniy.belyaev/Projects/trino-client-ruby/trino-client.gemspec:18.
WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0. While initializing your connection, use `#request(:basic_auth, ...)` instead. See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
|
RECORDING: I approved workflow run. |
takezoe
approved these changes
Dec 22, 2021
composerinteralia
added a commit
to composerinteralia/trino-client-ruby
that referenced
this pull request
Jun 4, 2024
Trino 1.0.2 includes some Faraday compatibility changes: treasure-data#73 treasure-data#75 But neither of those changes make the gem incompatible with Faraday 0.6.6. This commit relaxes the version so we can upgrade Presto and Faraday independently. Once we are on Faraday 1.x we can go back to the official release of this gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When using the current release (1.0.1), I've encountered some problems which this PR fixes:
model_versionsetting was not properly treated infaraday_clienthelper method due to operator priority (&&operator has higher priority than assignment operator)model_versioncheck expects numeric values, but module load treated the value as a string (by usinggsubmethod)has_rdocsettingFaraday deprecation message:
Gemspec deprecation message:
Overview
model_versionsettingfaradaydeprecationChecklist