Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc compiler fixes #108

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Jul 5, 2023

Most of them have to do with implicit casts - and sometimes comparing items of two different types of sizes can cause them to be stuck in loops if the bigger item is a number the smaller one can never be

The first commit clearly shows the useful changes, then I just tidied up formatting to be consistent

@clason
Copy link
Collaborator

clason commented Jul 14, 2023

@MDeiml would be nice to have this merged (and a new release made) for Neovim, which now bundles these parsers. (Speaking of releases: I'm trying to push semver for parsers, which makes patch releases for changes -- like this one -- that do not affect queries (fix), minor releases for changes that add to captures, meaning old queries keep working but lack new features (feat), and major releases for changes that remove/rename captures, meaning old queries no longer work (feat!).)

@MDeiml MDeiml merged commit aaf7679 into tree-sitter-grammars:split_parser Jul 22, 2023
2 checks passed
@MDeiml
Copy link
Collaborator

MDeiml commented Jul 22, 2023

Thanks. Sorry this took a while, am quite busy atm.

@MDeiml
Copy link
Collaborator

MDeiml commented Jul 22, 2023

@clason I'll try to stick to that. Feel free to mention me if I'm doing something wrong.

@David-Else
Copy link

@MDeiml It seems there has been quite a bit of activity here. The version Helix is currently using is 0.1.5, it would be great to get 0.1.6 into Helix too before the new Helix release that is happening very soon: helix-editor/helix#8086

@MDeiml
Copy link
Collaborator

MDeiml commented Sep 3, 2023

@David-Else I'm sorry that I'm not very active at the moment.

Not quite sure what you are aiming at? Do you mean I should update the helix configuration to use the new version of my parser (´0.1.6´)? I can create a PR.

@amaanq
Copy link
Member Author

amaanq commented Sep 3, 2023

If you're busy I can help maintain a healthy release cycle/manage issues @MDeiml (as I do for all upstream grammars)

@David-Else
Copy link

Do you mean I should update the helix configuration to use the new version of my parser (´0.1.6´)? I can create a PR.

@MDeiml Yes, that is what I had in mind :)

@MDeiml
Copy link
Collaborator

MDeiml commented Nov 5, 2023

@amaanq that would be awesome if the offer is still standing. I started full time working recently (was a student before) and don't really have time to do everything that I want to with this repo. Also got really bad at responding to issues 😅.

@amaanq
Copy link
Member Author

amaanq commented Nov 7, 2023

Of course! Though I'm a bit busier now with school and stuff - but I'm happy to maintain it

@MDeiml
Copy link
Collaborator

MDeiml commented Nov 10, 2023

I guess you would need some privileges for the repo?

@amaanq
Copy link
Member Author

amaanq commented Nov 10, 2023

Yep, you'd add me as a collaborator to the repo

@lewis6991
Copy link
Contributor

@MDeiml could you transfer this project to either @amaanq or me and we can add it to the https://github.com/tree-sitter-grammars org?

@clason
Copy link
Collaborator

clason commented Feb 13, 2024

If you want, of course. You'd keep write (but not admin) access, but you'd have people helping with routine maintenance and get a bunch of workflows for free ;) I'd also make it easier to adapt to the big upcoming changes in the tree-sitter ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants