Realloc open blocks when deserializing #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously deserializing assumed that open_blocks had enough capacity to deserialize all blocks. It appears that this is not always the case and that open blocks can overflow. This commit will realloc s->open_blocks if the current capacity is not big enough. Fixes tree-sitter-grammars#114 Fixes neovim/neovim#25164
Tree sitter generated parsers are different if you build on arm vs x86. This was causing the ci test to fail since I'm using an m1 mac, but the ci tests are using x86. Rebuilding in docker to fix that.
|
cc @MDeiml (not sure how to assign for review) |
|
looks good, surprised no one caught it before 😁 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously deserializing assumed that open_blocks had enough capacity to deserialize all blocks. It appears that this is not always the case and that open blocks can overflow.
This commit will realloc s->open_blocks if the current capacity is not big enough.
Fixes #114
Fixes neovim/neovim#25164
Note that I tested this on my machine with the steps/file that reproduces a crash in neovim/neovim#25164 and it worked reliably.