fix: use platform dependant build flags #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These bindings are autogenerated; please contribute improvements upstream (treesitter/treesitter). |
|
But the warning flag is not in the upstream bindings since it's not usually needed. |
|
Then why is this flag here? What's special about this parser so that it and no others requires the flag? |
|
The stub scanner functions that don't use the parameters. |
Co-authored-by: ObserverOfTime <chronobserver@disroot.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling on Windows fails currently because the flag
-Wno-unused-parameteris only valid for gcc, not for MSVC.This PR uses the
/wd4100flag instead when compiling on Windows.