-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #126
Fixes #126
Conversation
It would be better to separate the changing indentation, adding CI, ... from the actually grammar fix, otherwise it's hard to review. |
Normally I would - but I only changed one item by adding one character to it (null character for terminator, and you can see the change by clicking on that commit), I just found it a bit too insignificant to separate, sorry about that |
Also gonna add on that the problem could've been solved using dynamic precedence and setting qualified identifiers to -1, so that call_expression is preferred over that |
@amaanq FWIW this introduces a compiler warning when compiling tree-sitter-go, but I think it's an issue with tree-sitter proper: tree-sitter/tree-sitter#2490 |
Thanks for the report! I noticed that too so - this should fix it when ready: |
Mostly just prep for a new release
Closes #53