Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #126

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Fixes #126

merged 6 commits into from
Jul 26, 2023

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Jul 26, 2023

Mostly just prep for a new release

Closes #53

@amaanq amaanq requested a review from aryx July 26, 2023 06:06
@aryx
Copy link
Contributor

aryx commented Jul 26, 2023

It would be better to separate the changing indentation, adding CI, ... from the actually grammar fix, otherwise it's hard to review.
I'm ok with 1 single PR that does the indentation fix/adding CI/... but at least make a separate PR for the grammar change.

@amaanq
Copy link
Member Author

amaanq commented Jul 26, 2023

Normally I would - but I only changed one item by adding one character to it (null character for terminator, and you can see the change by clicking on that commit), I just found it a bit too insignificant to separate, sorry about that

@amaanq
Copy link
Member Author

amaanq commented Jul 26, 2023

Also gonna add on that the problem could've been solved using dynamic precedence and setting qualified identifiers to -1, so that call_expression is preferred over that

@amaanq amaanq merged commit 32ed43a into tree-sitter:master Jul 26, 2023
@Wilfred
Copy link

Wilfred commented Aug 12, 2023

@amaanq FWIW this introduces a compiler warning when compiling tree-sitter-go, but I think it's an issue with tree-sitter proper: tree-sitter/tree-sitter#2490

@amaanq
Copy link
Member Author

amaanq commented Aug 12, 2023

Thanks for the report! I noticed that too so - this should fix it when ready:

tree-sitter/tree-sitter#2488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function call parsed as a Type conversion
3 participants