-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to parse of type parameters #57
Conversation
Lgtm! |
Can you rebase to fix the conflicts (now that I've merged your other PR)? |
Those generated files in the repository are a bit annoying @maxbrunsfeld for reviewing and merging purposes. They generate extract conflicts. If people really need the parser.c, why we don't have separate repository with all those generated code. This would avoid having those huge PRs with thousands lines of code in parser.c that are not even inspected by humans. This also make the statistics on contributors useless. |
Rebased and regenerated parser (to fix conflict). It should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! This is great.
Thank you for reviews! |
Yeah we have an item in Tree-sitter’s 1.0 roadmap issue about changing how we store the generated files, but nobody is working on it right now. It’s going to take a bit of effort to design and set up the automation, and get the community migrated away from using the git repositories directly. |
ok, got it |
This PR adds support to parse of type parameters syntax, which will be added on Go 1.18.
TODO:
Checklist:
5 → 11. It's grown very much. I tried but I couldn't reduce it. Would you give me an advice?
1182 → 1220. I think it's reasonable.