Remove field_identifier from keyed_element #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes field_identifier from keyed_literal, since in the expression
T{k: v}
, k may be:There is no way to distinguish the first two cases without type information. Since expressions include identifiers, it's not necessary to add a special case for field_identifier, and it is incorrect when the identifier is actually a var or const.
Also, factor the grammar using commaSep.
Checklist: