Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(queries/highlight): highlight built-in functions as @function.builtin #96

Merged

Conversation

jimeh
Copy link
Contributor

@jimeh jimeh commented Dec 4, 2022

This PR supersedes #61 by fixing the scoping issue it has. I have been using this query since March 10th in my own Emacs config without any issues.

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@aryx
Copy link
Contributor

aryx commented Dec 6, 2022

@maxbrunsfeld any idea why we don't get any more CI jobs to check the PRs are correct?

@aryx aryx merged commit dfbef73 into tree-sitter:master Dec 6, 2022
@matoous matoous mentioned this pull request Dec 6, 2022
5 tasks
@jimeh jimeh deleted the add-highlight-query-for-built-in-functions branch December 13, 2022 08:23
@jimeh jimeh mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants