Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows attributes on promoted properties #190

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

gbprod
Copy link
Contributor

@gbprod gbprod commented Oct 20, 2023

This commit will correctly parse attributes on promoted properties.

This syntax is allowed and not recognize by this parser :

<?php

class B {
  public function __construct(
    #[A]
    public string $a,
  ) {
  }
}

Checklist:

  • All tests pass in CI
  • There are sufficient tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (0 new conflicts)
  • The parser size hasn't grown too much (master: 2642, PR: 2658)

This commit will correctly parse attributes on promoted properties.
@aryx aryx requested a review from cfroystad October 20, 2023 08:39
@aryx aryx merged commit 0e02e7f into tree-sitter:master Oct 20, 2023
3 checks passed
@gbprod gbprod deleted the fix-param-attributes branch October 20, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants