Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow digits in heredoc identifier #210

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

calebdw
Copy link
Collaborator

@calebdw calebdw commented Jan 22, 2024

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (0 new conflicts)
  • The parser size hasn't grown too much (master: STATE_COUNT, PR: STATE_COUNT)
    (check the value of STATE_COUNT in src/parser.c)

Hello! This PR closes #209 and allows digits in heredoc identifiers, which is valid PHP.

Thanks!

@amaanq amaanq merged commit 9704771 into tree-sitter:master Jan 22, 2024
4 checks passed
@calebdw calebdw deleted the 209-fix_heredoc_identifier branch January 22, 2024 13:51
@calebdw
Copy link
Collaborator Author

calebdw commented Jan 22, 2024

Thanks @amaanq!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: nowdoc string parsing breaks, if the identifier contains numbers
2 participants