Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 support and various fixes #214

Merged
merged 4 commits into from
Jan 26, 2024
Merged

PHP 8.3 support and various fixes #214

merged 4 commits into from
Jan 26, 2024

Conversation

calebdw
Copy link
Collaborator

@calebdw calebdw commented Jan 26, 2024

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (0 rules renamed)
  • The conflicts section hasn't grown too much ( 1 new conflicts)
  • The parser size hasn't grown too much (master: 2678, PR: 2681)
    (check the value of STATE_COUNT in src/parser.c)

Hello, this combines #200, #206, and #207 at the advice from @amaanq.

  • feat: add support for dynamic class constant fetch
  • fix: single types being incorrectly parsed as a union_type
  • fix: comment precedence

Closes #156, closes #197

Thanks!

@amaanq amaanq merged commit cd59e54 into tree-sitter:master Jan 26, 2024
4 checks passed
@calebdw calebdw deleted the combo branch January 26, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support php 8.3 PHP tags closed preceding a # character cause the rest of the line to interpret as a comment
2 participants