Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: clean up expressions #218

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

calebdw
Copy link
Collaborator

@calebdw calebdw commented Jan 31, 2024

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (1 rules renamed)
  • The conflicts section hasn't grown too much (0 new conflicts)
  • The parser size hasn't grown too much (master: 2727, PR: 2699)
    (check the value of STATE_COUNT in src/parser.c)

This cleans up some expressions:

  • the exponentiation_expression node has been removed and placed under binary_expression
  • the error suppression operator has been moved out of unary_op_expression and placed into a top level error_suppression_expression
  • fields were added to unary_op_expression and update_expression

Closes #114

@cfroystad
Copy link
Collaborator

This is once again great work! Thank you for all you've done to get this parser back up to speed.

This looks correct and should be working nicely. It's a pleasant surprise with the reduced state count!

Since this is a breaking change, we should keep in mind to increase the version number accordingly on the next release - I guess that means incrementing the minor rather than patch since we're yet to reach 1.0

@cfroystad cfroystad merged commit 71f56a9 into tree-sitter:master Feb 1, 2024
4 checks passed
@calebdw calebdw deleted the unary_fixes branch February 1, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnaryExpression
2 participants