Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forwarded parameters/arguments #191

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Oct 8, 2021

Adds support for forwarded arguments/parameters (...), for example:

def foo(...)
end

def foo(a, b, ...)
end

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@aibaars aibaars marked this pull request as ready for review October 8, 2021 11:34
end

def foo(a, b, ...)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add something to this test so that forward_argument is used too?

@aibaars aibaars merged commit bb6a42e into tree-sitter:master Oct 11, 2021
@aibaars aibaars linked an issue Nov 3, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to parse def foo(...)
2 participants