Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous (hash) splat arguments #233

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jan 9, 2023

From Ruby 3.2 release notes

Anonymous rest and keyword rest arguments can now be passed as arguments, instead of just used in method parameters. [Feature #18351]

 def foo(*)
   bar(*)
 end
 def baz(**)
   quux(**)
 end

This PR also upgrade the node-gyp version to solve a CI failure on the latest version of OSX: https://github.com/tree-sitter/tree-sitter-ruby/actions/runs/3873495109/jobs/6603577164

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

Copy link
Contributor

@hendrikvanantwerpen hendrikvanantwerpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the links to the release notes and issue, as well as updating the tests. That made reviewing very easy! It looks good to me.

@hendrikvanantwerpen hendrikvanantwerpen merged commit 7a1921b into tree-sitter:master Jan 10, 2023
@hendrikvanantwerpen
Copy link
Contributor

@aibaars I went ahead and merged this, as I wasn't sure if you could do that yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants