Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #68
This is yet a draft cause I have some questions:
What I already pushed make
type_identifier
andfield_identifier
to stop being final nodes to beThat would cause a massive test breakage
To avoid this level of breakage, a alternative would be making those like this:
But that would create a conflict:
So I would like to talk on what would be the best course of action here before going forward to fix the breakage on tests plus adding some more testings for raw identifiers