Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce parameter to download only the country without border countries #12

Closed
treee111 opened this issue Jul 1, 2021 · 5 comments · Fixed by #18
Closed

Introduce parameter to download only the country without border countries #12

treee111 opened this issue Jul 1, 2021 · 5 comments · Fixed by #18
Labels
enhancement New feature or request

Comments

@treee111
Copy link
Owner

treee111 commented Jul 1, 2021

However I found I actually don't need all 'border countries', if there is a parameter to ignore them.

from: #10

@treee111 treee111 added the enhancement New feature or request label Jul 1, 2021
@assofour
Copy link

assofour commented Jul 2, 2021

Let me guess, you may be from a European country, people travel across border there without any issue and quite seamlessly. In most of Asian countries, things are not like that. I believe only extreme few people in China would need border countries data. Also, it will bring in useless big country data such as Russia and India. It is absolutely impossible of a Chinese cyclist going into India by a bike.

@treee111
Copy link
Owner Author

treee111 commented Jul 2, 2021

yes, i'm from europe.
But you have to distinguish:
"Raw" .osm map-files

  • These are downloaded for all border countries and are big.
  • folder common_resources/maps

Generated tiles for ELEMNT

  • These are only generated for tiles with zoom-level 8 of the country and border tiles, where the choosen country is involved
  • Therefore, NOT all the downloaded border countries information/gigabyte are used

Example of the tile 204/112

  • china and vietnam are one one tile
  • therefore, the raw map of china and vietnam is downloaded
  • To generate the part of the tile where vietnam is involved, the raw .osm map of vietnam is used
  • if one would only process this tile, the output is only content of this tile, while having to download full raw files of china and vietnam
    image
    http://tools.geofabrik.de/map/#8/21.3445/105.8079&type=Geofabrik_Standard&grid=1

Nevertheless I got the point that downloading (not needed) border countries takes time and if one does not bike in this border areas and not crosses borders, we could only donload the choosen country-files and only process them into generated tiles.
Good point!

Does the explanation above makes sense to you?

@assofour
Copy link

assofour commented Jul 2, 2021

Yes. It makes sense.
In the doc QUICKSTART_MACOS.md , the title should be corrected to "Quick Start Guide for macOS".

treee111 pushed a commit that referenced this issue Jul 2, 2021
treee111 added a commit that referenced this issue Jul 4, 2021
- paramter to control download and processing of border countries or not
- CHANGLOG enhancements
treee111 added a commit that referenced this issue Jul 4, 2021
- paramter to control download and processing of border countries or not
- CHANGLOG enhancements
treee111 added a commit that referenced this issue Jul 4, 2021
- paramter to control download and processing of border countries or not
- CHANGLOG enhancements
@treee111
Copy link
Owner Author

treee111 commented Jul 4, 2021

Hi @assofour,
I developed that feature and published it in Version 0.5.0

you have to change parameter CALC_BORDER_COUNTRIES to False to not download the border countries:

# Calculate also border countries of input country or not
CALC_BORDER_COUNTRIES = True

Now you get faster processing times because only relevant countries are downloaded.
I'm happy for any feedback, feature requests or information in the case of errors! 👍

@assofour
Copy link

assofour commented Jul 5, 2021

@treee111 Great, will test it in next few days and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants