Skip unnecessary processing and other handling of zipping the output #40
Conversation
|
Are you sure about the ".v12" suffix. I am pretty sure it should only be ".12" (matching the current version). At least that is what I see on the device and which also makes that tile verification (for map and routing tiles) succeed in the Companion app. |
|
Great catch Michael. One downside for me, I have to redo and re-upload the whole planet almost to the hidrive... |
|
wow, this is a massive amount of features and checks implemented. Thanks @Ebe66! 👍 Somewhere, there is a failure under macOS when processing countries throught this branch with all the integrated changes. I would aim for splitting the changes into several, smaller branches / PR's. I extracted changes that belong together into separate PR's:
happy reviewing! ;-) |
|
Hi @Ebe66, Now I have prepared two more, which have most of the functionality and speed-boost I think.
After merging these two I compare your branch with develop and look out for changes I didn't catch until then. |
…. Use 'v12' tag (keep) filters (#46) - In the filter stage, do not re-convert the result file(s) back to .osm.pbf format. This saves some time here but more importantly osmconvert is much faster in cutting tiles out of o5m files then .osm.pbf files. - Switched to using 'v12' tag (keep) filters. This only keeps the tags used by Wahoo's devices render themes. Additionally, filter out all names tags except for those used, like city names. So highway names for example or filtered out. - At the start of the splitting phase check for the existence of a merged .osm.pbf file. This prevents unnecessary splitting tiles out of for instance Europe when the tile is already processed from a smaller, so faster, part like Germany. * takeover changes from #40 * osmium does not support writing to o5m format * Introduce Pull Request Template * [FEATURE] Add check for required input parameter for CLI and GUI (#41) - now not only for GUI but also for CLI the country argument is checked - added a check at the start to see if a country is to process is specified. Otherwise closing the GUI without selecting anything resulted in a runtime error. * [FEATURE] Enhance check for existing (already downloaded) polygons and .osm.pbf files (#43) - use the files modification date, not the creation time. On windows this seemed to occasionally see newly downloaded files as the ones they replaced. - check for a full match instead of doing a wildcard match while checking for existing maps. This prevents matching to multiple maps like australia and australia-oceania. * refactoring (pylint, formatting, comments) - change pylint findings - format constans on save - delete unused comments * don't really know what these lines are doing
See title and changelog.