ACLs: add deprecation banner #8057
Conversation
N-o-Z
added
the
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
| @@ -28,8 +28,10 @@ export const AuthLayout = () => { | |||
| <Container fluid="xl"> | |||
| <Row className="mt-5"> | |||
| <div> | |||
| <Alert variant="warning" title="ACL Deprecation"><InfoIcon/>{" "}<b>ACLs are moving out of core lakeFS!</b>{" "}See our <Alert.Link href={"https://lakefs.io/blog/why-moving-acls-out-of-core-lakefs/"}>announcement</Alert.Link>{" "} | |||
There was a problem hiding this comment.
60% of installations are single user anyway, and this is perhaps too intimidating. I suggest:
- put it only in the administration tab (dunno if hard to do, but nice to have - only show if
len(users) > 1) - change the wording: from "our annuncement" to "the announcement"
There was a problem hiding this comment.
- It's only in the administration tab + done
- Done
There was a problem hiding this comment.
Sorry to be contrary. Consider the fact that there is little reason for a user ever to go to the Admin tab. I would expect an admin of a medium-sized lakeFS installation to manage users maybe a few times a year.1 Such an admin would never see the deprecation banner.
Footnotes
-
Can we estimate whether this is true? ↩
There was a problem hiding this comment.
Though I understand your point, I think the decision on where to show it is a product one.
@ozkatz, do you still think we should place it only on the administration tab scope?
There was a problem hiding this comment.
I think so. >60% of users shouldn't care about this change, no reason to instill fear. On the other hand, while I agree with @arielshaqed that the admin page isn't visited frequently, it's still probably a higher frequency than upgrading lakeFS versions.
No perfect solution here..
Closes #8056
Preliminary signal for our users, expressing the intention to move ACLs