Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @75lb/deep-merge from 1.1.1 to 1.1.2 in /webui #8062

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 7, 2024

Bumps @75lb/deep-merge from 1.1.1 to 1.1.2.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

E2E Test Results - Quickstart

10 passed

Copy link

github-actions bot commented Aug 7, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@arielshaqed
Copy link
Contributor

[updating here]
This is definitely low risk. Any one of these two reasons alone would be enough to make it unusable:

  1. The attack is via prototype pollution into lodash merge methods. webui only ever uses lodash.noop directly. So any prototype pollution will not affect the data path on the GUI
  2. The only package in our package-lock actually using deep-merge is table-layout, and the path upwards to an app call is via jsdom, then either vitest or mathjax. vitest is unused, we don't run a vite test even in dev. mathjax appears via ipynb notebooks support. So the only way to pollute a prototype might be through a notebook stored in lakeFS - i.e. an by an authenticated user on a system whose server is specifically designed to keep an audit trail of all actions.

Definitely fix, but surely not in haste.

@arielshaqed
Copy link
Contributor

@dependabot rebase

Bumps [@75lb/deep-merge](https://github.com/75lb/deep-merge) from 1.1.1 to 1.1.2.
- [Commits](75lb/deep-merge@v1.1.1...v1.1.2)

---
updated-dependencies:
- dependency-name: "@75lb/deep-merge"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded and examined some random .ipynb object - looks good after the change. Good bot 🤖 !

@arielshaqed arielshaqed enabled auto-merge (squash) September 30, 2024 05:55
@arielshaqed arielshaqed added area/UI Improvements or additions to UI minor-change Used for PRs that don't require issue attached exclude-changelog PR description should not be included in next release changelog labels Sep 30, 2024
@arielshaqed
Copy link
Contributor

Oh no, it's the awful license/cla-is-stuck. Since pushing an empty commit will require another full Esti run, I'll just force-pull this one.

@arielshaqed arielshaqed merged commit 8493faa into master Sep 30, 2024
68 of 79 checks passed
@arielshaqed arielshaqed deleted the dependabot/npm_and_yarn/webui/75lb/deep-merge-1.1.2 branch September 30, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI Improvements or additions to UI dependencies Pull requests that update a dependency file exclude-changelog PR description should not be included in next release changelog javascript Pull requests that update Javascript code minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant