Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Dark Mode for Text Viewer #8371

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Support Dark Mode for Text Viewer #8371

merged 1 commit into from
Nov 14, 2024

Conversation

itaigilo
Copy link
Contributor

@itaigilo itaigilo commented Nov 14, 2024 •
edited
Loading

After the change:

Screenshot 2024-11-14 at 17 27 37

@itaigilo itaigilo added area/UI Improvements or additions to UI exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Nov 14, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

yonipeleg33
yonipeleg33 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@yonipeleg33 yonipeleg33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Can you attach a screenshot please?

@itaigilo
Copy link
Contributor Author

LGTM, thanks! Can you attach a screenshot please?

Added to the description.

@itaigilo itaigilo merged commit 068019a into master Nov 14, 2024
47 checks passed
@itaigilo itaigilo deleted the fix/support-dark-mode-for-text-viewer branch November 14, 2024 17:56
@itaigilo itaigilo added exclude-changelog PR description should not be included in next release changelog and removed exclude-changelog PR description should not be included in next release changelog labels Nov 14, 2024
@idanovo idanovo added include-changelog PR description should be included in next release changelog and removed exclude-changelog PR description should not be included in next release changelog labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonipeleg33 yonipeleg33 yonipeleg33 approved these changes

Assignees
No one assigned
Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itaigilo @yonipeleg33 @idanovo