Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: RepoManagementReadAll pull requests permissions #8374

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix: RepoManagementReadAll pull requests permissions #8374

merged 1 commit into from
Nov 15, 2024

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Nov 15, 2024

Closes #8373

@N-o-Z N-o-Z added bug Something isn't working include-changelog PR description should be included in next release changelog labels Nov 15, 2024
@N-o-Z N-o-Z requested review from itaigilo and guy-har November 15, 2024 16:54
@N-o-Z N-o-Z self-assigned this Nov 15, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

itaigilo
itaigilo reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using GET /pull for fetching PR details (on the UI).
So maybe this permission can't be removed?

@N-o-Z
Copy link
Member Author

N-o-Z commented Nov 15, 2024 •
edited
Loading

We're using GET /pull for fetching PR details (on the UI). So maybe this permission can't be removed?

There is no such thing as get permission for pull request there is either read or list

@N-o-Z N-o-Z merged commit 11b2d8a into master Nov 15, 2024
42 checks passed
@N-o-Z N-o-Z deleted the fix/repo-management-read-policy-8373 branch November 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaigilo itaigilo itaigilo approved these changes

@guy-har guy-har Awaiting requested review from guy-har

Assignees

@N-o-Z N-o-Z

Labels
bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix pullrequest permissions for RepoManagementReadAll policy
2 participants
@N-o-Z @itaigilo