Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB backups of deleted tables excluded #15

Closed
ryansb opened this issue Nov 3, 2020 · 3 comments
Closed

DynamoDB backups of deleted tables excluded #15

ryansb opened this issue Nov 3, 2020 · 3 comments

Comments

@ryansb
Copy link

ryansb commented Nov 3, 2020

First, thanks for adding DDB backups to 0.6.1.

Commit 0925415... / issue #14 added DDB backups as sub-resources to ddb/table. DynamoDB backups can exist of now-deleted tables that still need to be cleaned up.

To gather those, I think there needs to be a separate resource type ddb/backup added instead of backups being a sub-resource listed on existing tables. Another option would be to make a fake ddb/table resource with a status of DELETED and put those backups as sub-resources of.

@jcarter3
Copy link
Contributor

jcarter3 commented Nov 3, 2020

Ah, makes sense. I think moving ddb/backup to a separate resource type makes the most sense. It'd add a relation back to a potentially nonexistent table, but that should be fine? That is currently how RDS backups are handled (relationship goes to a non-existent database). I'll get that updated.

jcarter3 pushed a commit that referenced this issue Nov 4, 2020
@jcarter3
Copy link
Contributor

jcarter3 commented Nov 4, 2020

This should be fixed in the latest version (v0.6.2). Let me know if it's still not correct

@ryansb
Copy link
Author

ryansb commented Nov 4, 2020

Yeah that works perfectly! Having a semi-empty relationship when the DDB table is gone but backups still exist makes sense, since they really are orphaned resources.

@ryansb ryansb closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants