Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SetEtherSourceAddress -> SetSourceMacAddress #268

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Rename SetEtherSourceAddress -> SetSourceMacAddress #268

merged 1 commit into from
Nov 5, 2015

Conversation

yasuhito
Copy link
Member

@yasuhito yasuhito commented Nov 5, 2015

refs #249

@yasuhito yasuhito self-assigned this Nov 5, 2015
@yasuhito yasuhito added this to the 0.28.0 milestone Nov 5, 2015
houndci-bot
houndci-bot reviewed Nov 5, 2015
View reviewed changes
spec/pio/open_flow10/packet_out_spec.rb
When(:user_options) do
{
transaction_id: 0x16,
buffer_id: 0xffffffff,
in_port: 0xffff,
actions: Pio::OpenFlow10::SetEtherDestinationAddress.new('11:22:33:44:55:66'),
actions: Pio::OpenFlow10::SetDestinationMacAddress.new('11:22:33:44:55:66'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [86/80]

@yasuhito yasuhito merged commit 5e8bcb3 into develop Nov 5, 2015
@yasuhito yasuhito deleted the feature/set_source_mac_address branch November 5, 2015 00:24
@yasuhito yasuhito added the api label Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yasuhito yasuhito

Labels
api enhancement
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yasuhito @houndci-bot