Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade postgres and bytes dependencies. #678

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Upgrade postgres and bytes dependencies. #678

merged 3 commits into from
Jan 18, 2021

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented Jan 7, 2021

Pull request

Description

Upgrade postgres deps and as transitive dependency also bytes.

This pulls in tokio 1.0 but async-std is not yet compatible. We need to wait for async-rs/async-std#924 to be merged and released. Gotta keep this as draft until then.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested (by running the tests and a docker-compose with postgres source)
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

This was referenced Jan 7, 2021
Closed
Closed
Closed
@mfelsche mfelsche marked this pull request as draft January 7, 2021 14:19
@coveralls
Copy link
Collaborator

coveralls commented Jan 7, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 80.788% when pulling 29d7dd2 on postgres-dep-upgrade into e782f44 on main.

Licenser
Licenser previously approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 LGTM 👍

@mfelsche mfelsche added the blocked-on-external Blocked on external activity label Jan 7, 2021
@Licenser
Copy link
Member

The PR in question is merged and we are now on async std 1.9 does that unblock?

@Licenser Licenser force-pushed the postgres-dep-upgrade branch 2 times, most recently from 77ca248 to f35a87a Compare January 18, 2021 11:39
Licenser
Licenser previously approved these changes Jan 18, 2021
View reviewed changes
Upgrade postgres and bytes dependencies.
3fa9048 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Licenser
Licenser previously approved these changes Jan 18, 2021
View reviewed changes
@mfelsche mfelsche removed the blocked-on-external Blocked on external activity label Jan 18, 2021
Regenerate Cargo.lock
df554c5 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
@mfelsche mfelsche marked this pull request as ready for review January 18, 2021 12:51
Licenser
Licenser previously approved these changes Jan 18, 2021
View reviewed changes
Avoid huge ArrayPredicatePattern::Tilde struct variant (thanks clippy)
29d7dd2 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
@mfelsche mfelsche merged commit cf61402 into main Jan 18, 2021
@mfelsche mfelsche deleted the postgres-dep-upgrade branch January 18, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Licenser Licenser Licenser approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@darach darach Awaiting requested review from darach darach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfelsche @coveralls @Licenser