Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1605 add map save check #1684

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Conversation

kalitopix
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • [] If your PR contains DB doc changes have you made an API migration and a localDB migration if necessary?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [] Tests for the changes have been added (for bug fixes / features)
  • [] Passes e2e testing
  • [] Passes lint
  • [] Docs have been added / updated if necessary (for bug fixes / features)
  • What kind of change does this PR introduce?
    Add map save check

  • What is the current behavior?
    closes Add map save check #1605

  • Does this PR introduce a breaking change?
    No

@kalitopix kalitopix requested a review from rssk February 17, 2023 12:04
@rssk
Copy link
Contributor

rssk commented Oct 12, 2023

this still allows covariate fields that have not been mapped to still be saved, put a 'missing fields' instead of 'data map saved' and prevent saving
Screen Shot 2023-10-12 at 3 52 00 PM

@kalitopix kalitopix force-pushed the feature/1605-add-map-save-check branch from 77e2bc5 to 60f7d15 Compare October 13, 2023 14:16
@kalitopix kalitopix force-pushed the feature/1605-add-map-save-check branch from 60f7d15 to 3d0ddcd Compare October 13, 2023 16:03
@rssk rssk merged commit d2883ad into master Oct 18, 2023
1 check passed
@rssk rssk deleted the feature/1605-add-map-save-check branch October 18, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add map save check
2 participants