Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker sock option #1956

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Docker sock option #1956

merged 3 commits into from
Aug 28, 2024

Conversation

rssk
Copy link
Contributor

@rssk rssk commented Aug 28, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • If your PR contains DB doc changes have you made an API migration and a localDB migration if necessary?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Tests for the changes have been added (for bug fixes / features)
  • Passes e2e testing
  • Passes lint
  • Docs have been added / updated if necessary (for bug fixes / features)
  • What kind of change does this PR introduce?

Programmatically determines the docker context

  • What is the current behavior?
    Currently if a non standard context, or multiple engines are installed, odd behavior can occur

  • Does this PR introduce a breaking change?
    No

@rssk rssk merged commit 1c5dadd into master Aug 28, 2024
1 check passed
@rssk rssk deleted the docker-sock-option branch August 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant