test: reduce flakiness by taking control of environment #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use vs code with auto-attach, which creates data in STDERR This controls the ENV passed through to child-process Technically I think it improves the test:
Before
After
So technically what is happening is that the child process was receiving some ENV which told it to debug. I initially tried setting
LOG_LEVEL=fatal
, without passing anything fromprocess.env
; this was a mistake, asprocess.env.PATH
is needed (at least on my machine) to usenodejs
. So with that sent in, and a bit of pokery to getnpm run check
passing, this should meet standards.