Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown-in-html not always splitting HTML tags into separate lines (#558) #560

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

Crozzers
Copy link
Contributor

This PR fixes #558, which is a continuation from #546.

The issue is regarding markdown-in-html tags that are not on their own line. This issue was partially fixed in #547, but the solution was gated behind a check for if len(lines) < 3.
This check was based on the assumption that the snippets would look like this:

<div markdown="1">Some **text**
</div>

This assumption completely breaks down for longer snippets, leading to HTML tags not being properly split from the surrounding markdown.

This PR fixes this by always attempting to split the HTML tags into separate lines

@nicholasserra
Copy link
Collaborator

Thanks!

@nicholasserra nicholasserra merged commit b94feac into trentm:master Dec 26, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Table Conversion - Last Row Not Converted
2 participants