Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sbd discovery di #106

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Sbd discovery di #106

merged 2 commits into from
Sep 21, 2022

Conversation

arbulu89
Copy link
Contributor

User proper dependency injection in sbd discovery code and move test fixture files

@arbulu89 arbulu89 added the enhancement New feature or request label Sep 21, 2022
@arbulu89 arbulu89 requested a review from rtorrero September 21, 2022 12:27
rtorrero
rtorrero approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (minor comment included)

internal/cluster/sbd.go Show resolved Hide resolved
@arbulu89 arbulu89 merged commit 4c4f392 into main Sep 21, 2022
@stefanotorresi stefanotorresi deleted the sbd-discovery-di branch October 3, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtorrero rtorrero rtorrero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arbulu89 @rtorrero