Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GroupID field to the FactsGathered event mapping #125

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Oct 24, 2022

Based on: trento-project/contracts#26

I took advantage and cleaned some constants on the test using suite variables. Shared constants were confusing

@arbulu89 arbulu89 force-pushed the add-group-id-facts-gathered branch from eddf41d to d461e1b Compare November 2, 2022 08:51
@arbulu89 arbulu89 marked this pull request as ready for review November 2, 2022 08:53
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arbulu89 arbulu89 merged commit 2efd633 into main Nov 2, 2022
@arbulu89 arbulu89 deleted the add-group-id-facts-gathered branch November 2, 2022 13:09
@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants