Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packageversion gatherer #140

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

rtorrero
Copy link
Contributor

This PR adapts the packageversion gatherer to the latest changes to the fact gathering engine.

@rtorrero rtorrero marked this pull request as draft November 16, 2022 17:28
@rtorrero rtorrero force-pushed the packageversion_rtorrero branch from 356a20f to 5d533fe Compare November 16, 2022 17:29
@rtorrero rtorrero marked this pull request as ready for review November 16, 2022 17:36
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rtorrero ,
It looks good! Some small changes requested.
PD: I forsee conflicts, so maybe rebase main in

internal/factsengine/gatherers/packageversion.go Outdated Show resolved Hide resolved
internal/factsengine/gatherers/packageversion.go Outdated Show resolved Hide resolved
internal/factsengine/gatherers/packageversion.go Outdated Show resolved Hide resolved
@arbulu89 arbulu89 added the enhancement New feature or request label Nov 17, 2022
@rtorrero rtorrero force-pushed the packageversion_rtorrero branch from ec9b0cd to 74ed21b Compare November 17, 2022 12:43
@rtorrero rtorrero requested a review from arbulu89 November 17, 2022 12:44
@rtorrero rtorrero merged commit 773749c into trento-project:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants