Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load HANA database IP address in agent side #20

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Load HANA database IP address in agent side #20

merged 2 commits into from
Apr 19, 2022

Conversation

arbulu89
Copy link
Contributor

Cherry pick missing commit from legacy trento:

Based on PR: trento-project/trento#854

dottorblaster
dottorblaster approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my fault actually when porting the agent, thanks!

@dottorblaster dottorblaster merged commit d7cd057 into main Apr 19, 2022
@stefanotorresi stefanotorresi deleted the cherry-pick-dbaddress-field-implementation branch August 17, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@fabriziosestito fabriziosestito Awaiting requested review from fabriziosestito

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arbulu89 @dottorblaster