Publish csp information of a discovered pacemaker cluster #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
requested review from
dottorblaster,
arbulu89,
fabriziosestito,
rtorrero and
stefanotorresi
fabriziosestito
approved these changes
Apr 19, 2022
Interesting question, how does the runner deal with no provider provided? |
nelsonkopliku
force-pushed
the
publish_csp_for_a_discovered_cluster
branch
from
d371f40 to
b5a5aa2
Compare
arbulu89
reviewed
Apr 19, 2022
| Id string `mapstructure:"id"` | ||
| Name string `mapstructure:"name"` | ||
| DC bool `mapstructure:"dc"` | ||
| CloudProvider string `mapstructure:"cloud_provider"` |
There was a problem hiding this comment.
@nelsonkopliku Found this PR late...
We are using Provider term, and not CloudProvider as we will have non cloud based providers in the future.
Could we have a look on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR determines the CSP of a cluster.
Extracts the information the same way we do for the cloud discovery of a host.
Clearly the information published by the Designated Controller will be the truth.
Question: what if no CSP was provided? No big issue from agent side, as just an empty string will be published.
What about the checks engine?
Gonna check on this later on the control plane