Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cloud package tests #291

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Refactor cloud package tests #291

merged 4 commits into from
Nov 20, 2023

Conversation

arbulu89
Copy link
Contributor

Refactor cloud package tests

@arbulu89 arbulu89 force-pushed the refactor-cloud-package-tests branch from 9cec8fc to 8d71432 Compare November 13, 2023 08:34
@arbulu89 arbulu89 marked this pull request as ready for review November 13, 2023 11:09
@arbulu89 arbulu89 force-pushed the refactor-cloud-package-tests branch from b34e95d to 667bb61 Compare November 14, 2023 07:59
EMaksy
EMaksy reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey could not find anything :)

CDimonaco
CDimonaco approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just the comment, my ocd is triggered 👀

internal/core/cloud/metadata.go Outdated Show resolved Hide resolved
@arbulu89 arbulu89 merged commit 56711ae into main Nov 20, 2023
10 checks passed
@arbulu89 arbulu89 deleted the refactor-cloud-package-tests branch November 20, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMaksy EMaksy EMaksy left review comments

@CDimonaco CDimonaco CDimonaco approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
tech debt test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arbulu89 @nelsonkopliku @CDimonaco @EMaksy