Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http client refactor #300

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Http client refactor #300

merged 6 commits into from
Nov 21, 2023

Conversation

CDimonaco
Copy link
Member

Http Client refactor

  • Removed usage of http.DefaultClient in production code, allowed only in testing
  • Removed usage of http.NewRequest, using http.NewRequestWithContext
  • Context injection in the discovery interface
  • Context injection in soap/http clients
  • Context propagation

@CDimonaco CDimonaco requested a review from arbulu89 November 21, 2023 11:39
@CDimonaco CDimonaco self-assigned this Nov 21, 2023
nelsonkopliku
nelsonkopliku approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

arbulu89
arbulu89 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Thank you so much!

internal/core/cloud/azure.go Outdated Show resolved Hide resolved
internal/core/cloud/aws_test.go Show resolved Hide resolved
internal/discovery/cloud.go Show resolved Hide resolved
@arbulu89 arbulu89 added the enhancement New feature or request label Nov 21, 2023
@CDimonaco CDimonaco force-pushed the http_client_refactor branch from 99ec587 to 5f85760 Compare November 21, 2023 14:03
@CDimonaco CDimonaco merged commit 0a54f8f into main Nov 21, 2023
10 checks passed
@CDimonaco CDimonaco deleted the http_client_refactor branch November 21, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

Assignees

@CDimonaco CDimonaco

Labels
chore enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CDimonaco @nelsonkopliku @arbulu89