Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fact gathering errors #99

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Fact gathering errors #99

merged 4 commits into from
Sep 22, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Sep 20, 2022 •
edited
Loading

Add the FactGatheringError usage in the corosync.conf gatherer.

In case of an "abnormal" error doesn't allow to run properly the facts gathering (corosync file doesn't exist for example), a custom error is returned in the error parameter, and all the requests are filled with this error.

@arbulu89 arbulu89 force-pushed the fact-gathering-errors branch from 5324c52 to 6375c07 Compare September 20, 2022 14:49
@arbulu89 arbulu89 marked this pull request as ready for review September 20, 2022 14:54
rtorrero
rtorrero suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arbulu89! Some minor changes requested (open to discussion of course)

internal/factsengine/entities/facts_gathered.go Outdated Show resolved Hide resolved
internal/factsengine/gatherers/corosyncconf.go Outdated Show resolved Hide resolved
internal/factsengine/gatherers/corosyncconf_test.go Show resolved Hide resolved
CDimonaco
CDimonaco approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fabriziosestito
fabriziosestito approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dottorblaster
dottorblaster approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 force-pushed the fact-gathering-errors branch from 6375c07 to 5776694 Compare September 22, 2022 09:20
@arbulu89 arbulu89 requested a review from rtorrero September 22, 2022 09:21
@arbulu89 arbulu89 force-pushed the fact-gathering-errors branch from 5776694 to 99c1860 Compare September 22, 2022 09:22
@arbulu89 arbulu89 merged commit 6025297 into main Sep 22, 2022
@stefanotorresi stefanotorresi deleted the fact-gathering-errors branch October 3, 2022 11:07
@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDimonaco CDimonaco CDimonaco approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@nelsonkopliku nelsonkopliku Awaiting requested review from nelsonkopliku

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arbulu89 @dottorblaster @fabriziosestito @rtorrero @CDimonaco @nelsonkopliku