Add ADR 0009 for frontend directory structure #27
Conversation
dottorblaster
requested review from
fabriziosestito,
rtorrero,
nelsonkopliku,
CDimonaco,
arbulu89,
EMaksy and
jamie-suse
There was a problem hiding this comment.
It looks great @dottorblaster
A couple of comments and one question.
But I find it already mergable as well
|
|
||
| There may be some overhead associated with restructuring the frontend, such as updating dependencies, fixing references, or rewriting some parts of the application. However, in the long term, this new directory structure will ensure an organized and efficient system that can be easily maintained, scaled, and navigated. The new structure will also facilitate collaboration between developers as they will have a better understanding of where everything is located. | ||
|
|
||
| We have one drawback: action creators related to sagas now live along with slices and action creators generated by redux-toolkit. We found reasonable to have action creators all stuffed in one specific place, but it is well understood that it might not be the case for everyone. |
There was a problem hiding this comment.
What does this exactly mean?
That the content we have now in actions folder goes to the reducers file?
Each of the action respectively with the domain file?
There was a problem hiding this comment.
Exactly, we can squash all together 👍
|
|
||
| ## Decision | ||
|
|
||
| We propose the following new directory structure for the frontend of our software project: |
There was a problem hiding this comment.
Could we add some link to the react docs?
https://redux.js.org/faq/code-structure/
There was a problem hiding this comment.
Doin' this right now :D
| ``` | ||
| assets/js | ||
| ├── app.js | ||
| ├── common |
There was a problem hiding this comment.
Maybe it would be a good idea to define what this common holds.
According redux docs:
/common contains truly generic and reusable utilities and components.
Maybe we can put this sentence as paragraph below, so we have a written and aknowledged agreement hehe
There was a problem hiding this comment.
Yes you're totally right 👍
|
Just referencing trento-project/web#1355 |
dottorblaster
force-pushed
the
adr-fe-dir-structure
branch
from
9a514ca
to
af640bb
Compare
dottorblaster
force-pushed
the
adr-fe-dir-structure
branch
from
af640bb
to
31bf919
Compare
As above, just adding the accepted ADR for the new FE directory structure