This repository has been archived by the owner on May 30, 2022. It is now read-only.
Fix tags usage in the databases view #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi,
nelsonkopliku and
aleksei-burlakov
arbulu89
force-pushed
the
hotfix/fix-tags-databases-view
branch
from
7c13daa
to
a2efd0c
Compare
fabriziosestito
approved these changes
Oct 7, 2021
Yes, definitely; we'll also need to publish the API docs at some point. I will file a follow-up for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #308
The PR adds a new
api/databases/...endpoint to manage the tags. It mostly duplicates the code for the sap systems.I have changed a bit the sapsystems code to use the sapsystems service rather than consul. Which makes things a bit more cleaner.
It is true that the test code is almost a copy/paste, and I don't know if it makes sense to have something better.
PD: I don't know if it would make sense to add the
make swagto the genericmakecommand.I have noticed that some entries were not added