Configure NODE_PATH to load plugin from GitHub workspace (#19)

* test commit * test commit * test commit * test commit * test commit * test commit * test commit * test commit * test commit * test commit * test commit * test commit * test commit * test commit * ignore ds store * add dock * del
treosh · Dec 11, 2019 · 3da4a41 · 3da4a41
1 parent 7f0d318
commit 3da4a41
Show file tree

Hide file tree

Showing 9 changed files with 179 additions and 437 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,6 @@
 node_modules/**/*.ts
 results/
-.lighthouseci/
+.lighthouseci/
+
+node_modules/.yarn-integrity
+node_modules/**/.DS_Store
diff --git a/README.md b/README.md
@@ -386,6 +386,64 @@ against each of them. More details on this process are in the [Lighthouse CI doc
 
 </details>
 
+<details>
+ <summary>Use a Lighthouse plugin.</summary><br>
+
+#### main.yml
+
+```yml
+name: Lighthouse Audit
+on: push
+jobs:
+  lighthouse:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1 # checkout your own repo
+      - run: npm install # install your own dependencies
+      - name: Audit URLs using Lighthouse
+        uses: treosh/lighthouse-ci-action@v2
+        with:
+          urls: |
+            https://www.example.com/
+          configPath: ./lighthouserc.json
+      - name: Save results
+        uses: actions/upload-artifact@v1
+        with:
+          name: lighthouse-results
+          path: '.lighthouseci' # This will save the Lighthouse results as .json files
+```
+
+#### lighthouserc.json
+
+```json
+{
+  "ci": {
+    "collect": {
+      "settings": {
+        "plugins": [
+          "lighthouse-plugin-social-sharing"
+        ]
+      }
+    }
+  }
+}
+```
+
+#### package.json
+
+```json
+{
+  "name": "lighthouse-plugin-sample-project",
+  "devDependencies": {
+    "lighthouse-plugin-social-sharing": "0.0.1"
+  }
+}
+```
+
+[⚙️ See this example](https://github.com/connorjclark/lighthouse-plugin-sample-project)
+
+</details>
+
 Explore more workflows in [public examples](./.github/workflows).
 Submit a pull request with a new one if they don't cover your use case.
 

diff --git a/node_modules/.yarn-integrity b/node_modules/.yarn-integrity
diff --git a/node_modules/is-windows/index.js b/node_modules/is-windows/index.js
diff --git a/node_modules/is-windows/package.json b/node_modules/is-windows/package.json
diff --git a/node_modules/ws/lib/.DS_Store b/node_modules/ws/lib/.DS_Store
diff --git a/package.json b/package.json
@@ -12,7 +12,8 @@
   },
   "dependencies": {
     "@actions/core": "^1.2.0",
-    "@lhci/cli": "0.3.4"
+    "@lhci/cli": "0.3.4",
+    "is-windows": "^1.0.2"
   },
   "devDependencies": {
     "@types/node": "10",

diff --git a/src/index.js b/src/index.js
@@ -1,3 +1,15 @@
+// Append the node_modules of the github workspace and the node_modules of this action
+// to NODE_PATH. This supports lighthouse plugins - all the workspace needs to do is
+// `npm install` the plugin. The copy of lighthouse within this action will be used.
+
+const nodePathDelim = require('is-windows')() ? ';' : ':';
+const nodePathParts = [
+  ...(process.env.NODE_PATH || '').split(nodePathDelim),
+  `${__dirname}/../node_modules`,
+  `${process.env.GITHUB_WORKSPACE}/node_modules`,
+];
+process.env.NODE_PATH = nodePathParts.join(nodePathDelim);
+
 const core = require('@actions/core')
 const childProcess = require('child_process')
 const lhciCliPath = require.resolve('@lhci/cli/src/cli.js')

diff --git a/yarn.lock b/yarn.lock
@@ -1012,6 +1012,11 @@ is-typedarray@~1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/is-typedarray/-/is-typedarray-1.0.0.tgz#e479c80858df0c1b11ddda6940f96011fcda4a9a"
 
+is-windows@^1.0.2:
+  version "1.0.2"
+  resolved "https://registry.yarnpkg.com/is-windows/-/is-windows-1.0.2.tgz#d1850eb9791ecd18e6182ce12a30f396634bb19d"
+  integrity sha512-eXK1UInq2bPmjyX6e3VHIzMLobc4J94i4AWn+Hpq3OU5KkrRC96OAcR3PRJ/pGu6m8TRnBHP9dkXQVsT/COVIA==
+
 is-wsl@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/is-wsl/-/is-wsl-1.1.0.tgz#1f16e4aa22b04d1336b66188a66af3c600c3a66d"