New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update emoji in setFailedAnnotations #49

Merged

alekseykulikov merged 1 commit into treosh:master from paulirish:patch-1

Apr 10, 2020

Contributor

paulirish commented Apr 9, 2020

I'm not sure what the '🟡' glyph is, but it renders as a box on my machine.

I was just going to file that as a bug, but I figure why not just adopt the X and warning sign that are used right in the comment above. :)

Open to changing them, but just wanted 2 clear icons for these states.


          Update emoji in setFailedAnnotations

b4ede6f

alekseykulikov merged commit 2dc4281 into treosh:master

Member

alekseykulikov commented Apr 10, 2020 •

edited

Loading

Thanks, Paul! I agree with your choice of icons.

It suppose to be a yellow circle :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet