Upgrade cmake; fix typo

.github/workflows/build.yml

@@ -20,6 +20,10 @@ jobs:
     steps:
       - name: Configure git
         run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
+      - name: Update cmake
+        run: |
+          sudo snap install cmake --classic
+          alias cmake='snap run cmake'
       - name: Check out
         uses: actions/checkout@v3
         with:

CMakeLists.txt

@@ -641,7 +641,7 @@ ELSE()
 ENDIF(WANT_DEBUG_FPE)
 
 if(WANT_DEBUG_CPACK)
-	if(LMMS_BUILD_WIN32 OR WANT_CPACK_TARBALL)
+	if((LMMS_BUILD_WIN32 AND CMAKE_VERSION VERSION_LESS "3.19") OR WANT_CPACK_TARBALL)
 		set(STATUS_DEBUG_CPACK "Wanted but disabled due to unsupported configuration")
 	else()
 		set(CPACK_DEBUG TRUE)

cmake/linux/CPackAppImage.cmake

@@ -168,7 +168,7 @@ execute_process(COMMAND "${LINUXDEPLOYQT_BIN}" "${DESKTOP_FILE}" ${EXECUTABLES}
 	-bundle-non-qt-libs
 	-verbose=${VERBOSITY}
 	${NO_STRIP}
-	COMMAND_ECHO ${COMMAND_ECHO})
+	COMMAND_ECHO ${COMMAND_ECHO}
 	COMMAND_ERROR_IS_FATAL ANY)
 	#-unsupported-allow-new-glibc
 

cmake/nsis/CMakeLists.txt

@@ -69,6 +69,11 @@ SET(CPACK_NSIS_DEFINES                  "${CPACK_NSIS_DEFINES}" PARENT_SCOPE)
 SET(CPACK_PACKAGE_ICON                  "${CPACK_PACKAGE_ICON}" PARENT_SCOPE)
 SET(CPACK_NSIS_MUI_ICON                 "${CPACK_NSIS_MUI_ICON}" PARENT_SCOPE)
 
+if(CPACK_DEBUG)
+	# CMake 3.19+
+	set(CPACK_NSIS_EXECUTABLE_PRE_ARGUMENTS "-V4")
+endif()
+
 # Windows resource compilers
 CONFIGURE_FILE("lmms.rc.in"             "${CMAKE_BINARY_DIR}/lmms.rc")
 CONFIGURE_FILE("zynaddsubfx.rc.in"      "${CMAKE_BINARY_DIR}/plugins/ZynAddSubFx/zynaddsubfx.rc")