Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to centre justify step group steps #333

Closed
trevorsandy opened this issue Aug 31, 2019 · 4 comments
Closed

Add option to centre justify step group steps #333

trevorsandy opened this issue Aug 31, 2019 · 4 comments
Assignees
Milestone

Comments

@trevorsandy
Copy link
Owner

trevorsandy commented Aug 31, 2019

Subject

Add option to centre justify Step Group and Callout steps.

Environment

Version of LPub3D - 2.3.13
Operating system - All

Expected behaviour

Have an option to automatically place steps in a Step Group or multi step Callout at the vertical centre, horizontal centre or dead centre of its bounding region.

Current behaviour

Steps are justified left when vertical allocation is specified or towards the divider when divider is specified and the allocation is horizontal.

Solution

Add ‘Justify’ drop-down and ‘Centre spacing’ dialogue to Step Group and Callout Setup dialogues. The Centre drop-down offers options to center justify steps vertically, horizontally and dead centre plus the default left justify - the behaviour before this enhancement.

When a step is centred, all allocated margins are repurposed and applied as specified across the left, right, top or bottom regions of the step - minus the centre spacing value between items.

Centre justify behaviour can be applied to Callouts and multiple steps within a Callout.

@trevorsandy trevorsandy self-assigned this Aug 31, 2019
@trevorsandy trevorsandy added this to the v2.3.13 milestone Aug 31, 2019
@trevorsandy
Copy link
Owner Author

trevorsandy commented Aug 31, 2019

Implemented.

Example steps centred vertically:

Screenshot - 04_09_2019 , 08_44_46
Screenshot - 04_09_2019 , 08_45_40
Screenshot - 04_09_2019 , 09_02_44
Screenshot - 04_09_2019 , 09_13_00
Screenshot - 04_09_2019 , 09_13_42
Screenshot - 04_09_2019 , 09_07_04
Screenshot - 04_09_2019 , 09_11_24

Cheers,

@jacovandermolen
Copy link

Great feature!

@trevorsandy
Copy link
Owner Author

Hi Jaco, Indeed.

This one was a little stinker to get right.

Please be advised that some of the graphics in this ticket are not up to date. Specifically the Step Group Setup dialogue which now has a drop-down and double spinner dialogue. Moreover, the meta command shown to center items has changed. I’ll update the ticket graphics shortly.

Cheers,

@trevorsandy
Copy link
Owner Author

Implemented.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants