Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Stellar: add support for StellarManageBuyOfferOp and StellarPathPaymentStrictSendOp. #930

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Nov 5, 2021

continuation of trezor/trezor-firmware#1838

  • updated trezor-common
  • rename StellarManageOfferOp to StellarManageSellOfferOp
  • rename StellarPathPaymentOp to StellarPathPaymentStrictReceiveOp
  • rename StellarCreatePassiveOfferOp to StellarCreatePassiveSellOfferOp
  • add support for StellarManageBuyOfferOp
  • add support for StellarPathPaymentStrictSendOp

In c933d23, I only submitted changes related to Stellar.

I hope I didn't miss anything else, please let me know if there is any.

@overcat overcat force-pushed the stellar-new-ops branch 2 times, most recently from 289aab5 to 1f8d1c4 Compare November 5, 2021 09:51
@overcat overcat marked this pull request as ready for review November 5, 2021 10:04
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tests are passing (except for cardano but this is expected, there were some more changes in firmware that will be reflected in another PR).
I shall merge it tomorrow I think.

@overcat
Copy link
Contributor Author

overcat commented Nov 11, 2021

Rebased.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants