Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit cython version used for hidapi 0.7.x #173

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

makinbacon21
Copy link

Will not build otherwise

@makinbacon21
Copy link
Author

whoops needs more tacked onto this...will do more research

@makinbacon21
Copy link
Author

Nevermind! I just forgot how python deps worked. This compiles fine. My apologies for the confusion.

@makinbacon21 makinbacon21 reopened this Feb 13, 2024
@prusnak
Copy link
Member

prusnak commented Feb 13, 2024

Do not use hidapi 0.7.x but use the latest

@prusnak prusnak closed this Feb 13, 2024
@makinbacon21
Copy link
Author

mbed os (extremely popular and industry standard project) relies heavily on 0.7.x on non-Linux platforms and 0.7.x has received a great many updates. It would be trivial to add one more update so it at least compiles.

@prusnak
Copy link
Member

prusnak commented Feb 13, 2024

I am confused, in one post you say there is a problem, in another you say it compiles, then you again say it does not compile.

@makinbacon21
Copy link
Author

That is my point--mbed OS's Python tools on non-Linux platforms currently do not compile because it relies on cython-hidapi v0.7.x and this version does not compile since the release of Cython 3. See https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt#L20

@prusnak prusnak reopened this Feb 13, 2024
@prusnak prusnak merged commit 15dcc12 into trezor:0.7.x Feb 13, 2024
@prusnak
Copy link
Member

prusnak commented Feb 13, 2024

@makinbacon21 Please tell mbed os maintainers to open an issue in this repo so we can get the latest hidapi building for non-linux mbed os. Using old version is a bad workaround. We should fix the real problem.

@makinbacon21
Copy link
Author

I'll add an issue--thanks. In the meantime, can we tag .post22 and put on pypi?
Anyway, thank you for your help and work on this project.

@prusnak
Copy link
Member

prusnak commented Feb 13, 2024

I will wait until we know what is the real issue. Maybe it is less work for me to fix it rather than spend my time doing a release for an ancient version.

Mbed can still use the github as source instead of the pypi: https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source

@makinbacon21
Copy link
Author

makinbacon21 commented Feb 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants