-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit cython version used for hidapi 0.7.x #173
Conversation
Will not build otherwise
whoops needs more tacked onto this...will do more research |
Nevermind! I just forgot how python deps worked. This compiles fine. My apologies for the confusion. |
Do not use hidapi 0.7.x but use the latest |
mbed os (extremely popular and industry standard project) relies heavily on 0.7.x on non-Linux platforms and 0.7.x has received a great many updates. It would be trivial to add one more update so it at least compiles. |
I am confused, in one post you say there is a problem, in another you say it compiles, then you again say it does not compile. |
That is my point--mbed OS's Python tools on non-Linux platforms currently do not compile because it relies on cython-hidapi v0.7.x and this version does not compile since the release of Cython 3. See https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt#L20 |
@makinbacon21 Please tell mbed os maintainers to open an issue in this repo so we can get the latest hidapi building for non-linux mbed os. Using old version is a bad workaround. We should fix the real problem. |
I'll add an issue--thanks. In the meantime, can we tag .post22 and put on pypi? |
I will wait until we know what is the real issue. Maybe it is less work for me to fix it rather than spend my time doing a release for an ancient version. Mbed can still use the github as source instead of the pypi: https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source |
My guess is it's lack of care to update their usage of the interface on their end rather than some unfixed issue on yours. I have opened an issue and if that is unproductive I will fix next week; very busy this week. Thanks again for the help--I'm glad at least a fix is on the official repo so I can direct others to use for the time being.
…________________________________
From: Pavol Rusnak ***@***.***>
Sent: Tuesday, February 13, 2024 12:35:30 PM
To: trezor/cython-hidapi ***@***.***>
Cc: Thomas Makin ***@***.***>; Mention ***@***.***>
Subject: Re: [trezor/cython-hidapi] limit cython version used for hidapi 0.7.x (PR #173)
I will wait until we know what is the real issue. Maybe it is less work for me to fix it rather than spend my time doing a release for an ancient version.
—
Reply to this email directly, view it on GitHub<#173 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEXR77UF5YEMOIJK6L5XB3DYTOP6FAVCNFSM6AAAAABDG4DFESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSGA3TENZZGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Will not build otherwise