Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/t3b1 json #103

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix/t3b1 json #103

merged 2 commits into from
Oct 9, 2024

Conversation

komret
Copy link
Contributor

@komret komret commented Sep 30, 2024

  1. Make sure check_releases.py is applied to all device models without having to list them explicitly. We forgot to add T3T1 and T3B1 which lead to an uncaught error in JSON formatting (see 2).
  2. Fix the formatting error. JSON could not be parsed correctly which lead to a bug in Suite, see Improve error handling in firmware revision check trezor-suite#14626.

The error is caught when only the first commit is applied:
Screenshot 2024-09-30 at 16 34 52

@matejcik matejcik removed their request for review October 4, 2024 09:01
@vdovhanych vdovhanych merged commit f5511b6 into master Oct 9, 2024
2 checks passed
@vdovhanych vdovhanych deleted the fix/t3b1-json branch October 9, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants