Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: invalid homescreen leads to bootloop #1118

Closed
matejcik opened this issue Jul 21, 2020 · 4 comments · Fixed by #1205
Closed

core: invalid homescreen leads to bootloop #1118

matejcik opened this issue Jul 21, 2020 · 4 comments · Fixed by #1205
Labels
bug Something isn't working as expected core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Milestone
2020-09

Comments

@matejcik
Copy link
Contributor

matejcik commented Jul 21, 2020 •
edited
Loading

setting an invalid TOIF image (with a valid header) as a homescreen will cause the device to endlessly loop while trying to render it. the only way to recover is to do a bootloader wipe.

to reproduce:

use the following file
bad-noise.toif.txt
after downloading, rename to bad-noise.toif
then:

trezorctl set-homescreen -f bad-noise.toif

@bosomt can you please test older firmwares if they have the same problem?
@matejcik matejcik added the bug Something isn't working as expected label Jul 21, 2020
@matejcik
Copy link
Contributor Author

the problem is that apply_settings does not check validity of the image

@matejcik matejcik added the core Trezor Core firmware. Runs on Trezor Model T and T2B1. label Jul 21, 2020
@bosomt
Copy link

bosomt commented Jul 21, 2020

@matejcik
same behavior with 2.3.0 and 2.3.1 /production versions/
only way to recover was to wipe it including bootloader

@prusnak prusnak added this to the backlog milestone Jul 22, 2020
@tsusanka tsusanka mentioned this issue Jul 23, 2020
Merged
@mmilata mmilata mentioned this issue Aug 19, 2020
Merged
@tsusanka tsusanka modified the milestones: backlog, 2020-09 Aug 21, 2020
@bosomt
Copy link

bosomt commented Aug 24, 2020 •
edited
Loading

QA OK

Test enviroment
FW: trezor-fw-regular-2.3.3-e137f196
OS: Nixos
trezorctl 0.12.0

result

tomas@tomas:~]$ trezorctl set-homescreen -f ./Downloads/bad-noise.toif Error: DataError: Invalid homescreen

@tsusanka tsusanka mentioned this issue Aug 25, 2020
Closed
@sorooris
Copy link
Contributor

QA OK

device: model T 2.3.3 df5421e
trezorctl 0.12.1
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
None yet
Milestone
2020-09
Development

Successfully merging a pull request may close this issue.

core: fix boot loop after uploading invalid homescreen trezor/trezor-firmware
6 participants
@prusnak @mmilata @matejcik @tsusanka @sorooris @bosomt