Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix boot loop after uploading invalid homescreen #1205

Merged
merged 1 commit into from
Aug 21, 2020
Merged

core: fix boot loop after uploading invalid homescreen #1205

merged 1 commit into from
Aug 21, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Aug 19, 2020

Fixes #1118.

Question: is the micropython C api documented anywhere?

tsusanka
tsusanka reviewed Aug 19, 2020
View reviewed changes
core/CHANGELOG.md Outdated Show resolved Hide resolved
core/src/apps/management/apply_settings.py Outdated Show resolved Hide resolved
core/src/apps/management/apply_settings.py Outdated Show resolved Hide resolved
tests/device_tests/test_msg_applysettings.py Show resolved Hide resolved
@tsusanka
Copy link
Contributor

Question: is the micropython C api documented anywhere?

There is not much at http://docs.micropython.org/en/latest/ ? Maybe @prusnak or @jpochyla might direct us somewhere but I am doubtful

@mmilata mmilata requested review from tsusanka and prusnak August 20, 2020 11:17
tsusanka
tsusanka approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@tsusanka tsusanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash.

@prusnak
Copy link
Member

prusnak commented Aug 20, 2020

I learned the API by reading other extmod modules and by writing the extmod-generator: https://github.com/prusnak/micropython-extmod-generator Not too much official documentation though ...

@andrewkozlik andrewkozlik removed their request for review August 20, 2020 15:59
@mmilata mmilata force-pushed the mmilata/invalid-homescreen-bootloop branch from 39d0f79 to 3e251f8 Compare August 20, 2020 22:46
@mmilata
Copy link
Member Author

mmilata commented Aug 20, 2020

Squashed & rebased.

@tsusanka
Copy link
Contributor

tsusanka commented Aug 21, 2020 •
edited
Loading

@prusnak do you still want to have another look? You are still noted as "requesting change".

@tsusanka tsusanka added this to the 2020-09 milestone Aug 21, 2020
@prusnak prusnak merged commit 1b98265 into master Aug 21, 2020
@prusnak prusnak deleted the mmilata/invalid-homescreen-bootloop branch August 21, 2020 10:00
@tsusanka
Copy link
Contributor

tsusanka commented Aug 21, 2020 •
edited
Loading

@matejcik same as with #1189 please take a quick look.

@mmilata mmilata added needs QA and removed needs QA labels Aug 21, 2020
@matejcik
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsusanka tsusanka tsusanka approved these changes

@prusnak prusnak prusnak approved these changes

@matejcik matejcik Awaiting requested review from matejcik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2020-09
Development

Successfully merging this pull request may close these issues.

core: invalid homescreen leads to bootloop
4 participants
@mmilata @tsusanka @prusnak @matejcik