-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow spending coins from Bitcoin paths if the coin has implemented strong replay protection #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
force-pushed
the
allow-invalid-paths-forkid
branch
2 times, most recently
from
August 15, 2020 22:32
41b0038
to
a7d35be
Compare
prusnak
force-pushed
the
allow-invalid-paths-forkid
branch
2 times, most recently
from
August 16, 2020 09:35
dfe65d2
to
7364b29
Compare
tsusanka
reviewed
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one question.
tsusanka
approved these changes
Aug 19, 2020
has implemented strong replay protection via SIGHASH_FORKID
has implemented strong replay protection via SIGHASH_FORKID
prusnak
force-pushed
the
allow-invalid-paths-forkid
branch
from
August 19, 2020 17:32
7364b29
to
806c7d6
Compare
Rebased to resolve the merge conflict |
tsusanka
approved these changes
Aug 19, 2020
I am merging this because we want to include it in today's Freeze. But @matejcik please have a look at this "post mortem" just to make sure. |
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow spending coins from Bitcoin paths if the coin has implemented strong replay protection via
SIGHASH_FORKID
.Fixes #1188