Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spending coins from Bitcoin paths if the coin has implemented strong replay protection #1189

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 15, 2020

Allow spending coins from Bitcoin paths if the coin has implemented strong replay protection via SIGHASH_FORKID.

Fixes #1188

@prusnak prusnak added this to the 2020-09 milestone Aug 15, 2020
@prusnak prusnak force-pushed the allow-invalid-paths-forkid branch 2 times, most recently from 41b0038 to a7d35be Compare August 15, 2020 22:32
@prusnak prusnak force-pushed the allow-invalid-paths-forkid branch 2 times, most recently from dfe65d2 to 7364b29 Compare August 16, 2020 09:35
Copy link
Contributor

@tsusanka tsusanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one question.

legacy/firmware/crypto.c Show resolved Hide resolved
@prusnak prusnak force-pushed the allow-invalid-paths-forkid branch from 7364b29 to 806c7d6 Compare August 19, 2020 17:32
@prusnak
Copy link
Member Author

prusnak commented Aug 19, 2020

Rebased to resolve the merge conflict

@tsusanka tsusanka merged commit 68e119c into master Aug 21, 2020
@tsusanka tsusanka deleted the allow-invalid-paths-forkid branch August 21, 2020 09:49
@tsusanka
Copy link
Contributor

tsusanka commented Aug 21, 2020

I am merging this because we want to include it in today's Freeze. But @matejcik please have a look at this "post mortem" just to make sure.

@matejcik
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow spending coins from invalid paths if the chain offers strong replay protection.
3 participants