Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-32 path schema support #1135

Closed
matejcik opened this issue Jul 24, 2020 · 1 comment · Fixed by #1184
Closed

BIP-32 path schema support #1135

matejcik opened this issue Jul 24, 2020 · 1 comment · Fixed by #1184
Assignees
@matejcik
Labels
code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Milestone
21.01

Comments

@matejcik
Copy link
Contributor

To fix the rest of #1064 and implement stronger checks in individual operations, we want to be able to specify BIP-32 path schemas in code in some human-readable (and writable) form.

I have a working sample of this, PR will follow shortly.

It might also be beneficial to use this in Keychain instead of namespaces.
@matejcik matejcik added core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature labels Jul 24, 2020
@matejcik matejcik added this to the 2020-09 milestone Jul 24, 2020
@matejcik matejcik self-assigned this Jul 24, 2020
@matejcik matejcik mentioned this issue Jul 24, 2020
Merged
@matejcik
Copy link
Contributor Author

as part of this let's also improve readability or documentation of the Keychain code, in particular: #1126 (comment)

@tsusanka tsusanka linked a pull request Aug 19, 2020 that will close this issue
BIP-32 path schemas #1184
Merged
@tsusanka tsusanka modified the milestones: 2020-09, 2020-10 Aug 19, 2020
@matejcik matejcik mentioned this issue Sep 18, 2020
Closed
@tsusanka tsusanka modified the milestones: 2020-10, 2020-11 Oct 1, 2020
@tsusanka tsusanka added the code Code improvements label Oct 23, 2020
@tsusanka tsusanka modified the milestones: 2020-11, 2020-12 Nov 6, 2020
@tsusanka tsusanka modified the milestones: 2020-12, 2021-01 Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
code Code improvements core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
None yet
Milestone
21.01
Development

Successfully merging a pull request may close this issue.

BIP-32 path schemas trezor/trezor-firmware
2 participants
@matejcik @tsusanka