Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strengthen soft-checks in get_address and similar #1137

Closed
tsusanka opened this issue Jul 24, 2020 · 2 comments
Closed

Strengthen soft-checks in get_address and similar #1137

tsusanka opened this issue Jul 24, 2020 · 2 comments
Assignees
@tsusanka

Comments

@tsusanka
Copy link
Contributor

Follow-up of #1064. Let's strengthen soft-checks in get_address and similar to a hard fail unless the "safety_checks" setting is not set.

Let me discuss this in Product first, this can be sensitive for some 3rd parties.
@tsusanka tsusanka added enhancement feature Product related issue visible for end user labels Jul 24, 2020
@tsusanka tsusanka added this to the backlog milestone Jul 24, 2020
@tsusanka tsusanka self-assigned this Jul 24, 2020
@tsusanka tsusanka mentioned this issue Jul 24, 2020
Closed
3 tasks
@matejcik matejcik mentioned this issue Aug 14, 2020
Closed
@tsusanka tsusanka removed the feature Product related issue visible for end user label Sep 17, 2020
@tsusanka
Copy link
Contributor Author

tsusanka commented Sep 18, 2020 •
edited
Loading

In particular trezorctl btc get-address -n "m/44'/0'/1000000'/0/0" should raise an error unless the safety_checks are set to Prompt.

@matejcik
Copy link
Contributor

can we maybe close this in favor of #1135 ?
PR: #1184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsusanka tsusanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matejcik @tsusanka